[RELAY]Reduce ops sum/max/min/mean/prod #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Oct 18, 2018
python/tvm/relay/op/reduce.py
Outdated
| def sum(data, axis=None, keepdims=False, exclude=False): | ||
| """Computes the sum of array elements over given axes. | ||
|
|
||
| Example:: |
There was a problem hiding this comment.
remove example for now, as this is not executable for now
src/relay/op/tensor/reduce.cc
Outdated
| if (data == nullptr) return false; | ||
| CHECK(static_cast<int>(data->shape.size()) != 0); | ||
| std::vector<IndexExpr> in_shape; | ||
| for (auto i : data->shape) { |
There was a problem hiding this comment.
src/relay/op/tensor/reduce.cc
Outdated
| .describe(R"code(Computes the min of array elements over given axes. | ||
|
|
||
| )code" TVM_ADD_FILELINE) | ||
| .set_num_inputs(1) |
There was a problem hiding this comment.
siju-samuel
force-pushed
the
relay_reduce_ops
branch
from
21acafe
to
620fd9e
Compare
|
please rebase against master after #1934 to make use of the newly introduced API and add test-case to make sure text format works. |
siju-samuel
force-pushed
the
relay_reduce_ops
branch
from
7e8c505
to
bf62afc
Compare
tqchen
requested changes
Oct 21, 2018
python/tvm/relay/op/reduce.py
Outdated
| result : relay.Expr | ||
| The computed result. | ||
| """ | ||
|
|
python/tvm/relay/op/reduce.py
Outdated
| result : relay.Expr | ||
| The computed result. | ||
| """ | ||
|
|
tqchen
requested changes
Oct 21, 2018
tests/python/relay/test_op_level4.py
Outdated
| if __name__ == "__main__": | ||
| test_binary_op() | ||
| test_cmp_type() | ||
| test_binary_int_broadcast() | ||
| test_where() | ||
| test_arg_reduce() | ||
| test_multibox_prior() |
There was a problem hiding this comment.
multibox_prior does not belong to this file
siju-samuel
force-pushed
the
relay_reduce_ops
branch
from
d2a39df
to
755ae67
Compare
tqchen
approved these changes
Oct 21, 2018
tqchen
added
status: accepted
and removed
status: need update
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1799
Level 4 Ops
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.