[Bugfix][Relax] Set purity=false for LazySetOutput #17119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `relax.transform.LazySetOutput` transformation updates a Relax function to produce output from a `fset_output` callback. In the initial implementation, the `fset_output` was marked as a pure function, which allowed it to be erroneously removed from a function. This commit updates the `relax::FuncStructInfo` used to annotate `fset_output`, marking it as an impure function.
yongwww
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
relax.transform.LazySetOutputtransformation updates a Relax function to produce output from afset_outputcallback. In the initial implementation, thefset_outputwas marked as a pure function, which allowed it to be erroneously removed from a function.This commit updates the
relax::FuncStructInfoused to annotatefset_output, marking it as an impure function.