Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FP8][Codegen] Add make_fp8 vector constructors #17065

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[FP8][Codegen] Add make_fp8 vector constructors #17065

merged 2 commits into from
Jun 5, 2024

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Jun 5, 2024

This allows vectorized fp8 loading.

Co-authored-by: Chris Sullivan <csullivan@octo.ai>

cc @yongwww @csullivan @tqchen

yongwww
yongwww approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vinx13 vinx13 changed the title [FP8][Codegen] Add make_fp8 vector constructors. [FP8][Codegen] Add make_fp8 vector constructors Jun 5, 2024
@csullivan csullivan merged commit 2a62c72 into apache:main Jun 5, 2024
20 checks passed
@ysh329 ysh329 mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongwww yongwww yongwww approved these changes

@csullivan csullivan Awaiting requested review from csullivan

@tqchen tqchen Awaiting requested review from tqchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinx13 @yongwww @csullivan