[TIR] Support narrow dtype for let binding #16947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hzfengsy
force-pushed
the
fix_narrow_dtype
branch
2 times, most recently
from
8c229e2
to
2acc672
Compare
The current pass `ForceNarrowIndexToI32` fails to narrow dtype for let binding. This PR fixes the issue. BTW, this PR addresses the comments in apache#16934
|
Would be great if you guys can help review this one |
tqchen
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current pass
ForceNarrowIndexToI32fails to narrow dtype for let binding. This PR fixes the issue.BTW, this PR addresses the comments in #16934
cc @tqchen @Lunderberg