[SVE] Check for SVE target in VectorizeLoop #16893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekalda
commented
Apr 16, 2024
|
This is a follow up from #16782, it makes sure that scalable vectors are created only for SVE target. In this implementation we check for target in function attributes, so we'd rely on |
ekalda
force-pushed
the
target-in-loopvectorizer
branch
from
9b91c53
to
8c95c41
Compare
ekalda
changed the title
|
I moved the implementation to use the current target since changing the graph executor's pipeline is breaking lots of CUDA tests. |
lhutton1
reviewed
Apr 19, 2024
Check that we are compiling for an SVE enabled target when the extent of a loop marked for vectorizing has a vscale dependent extent.
Use Target::Current() in LoopVectorizer to check for SVE Change-Id: I15363bad540d6752d6c2098c93efce25c107309b
Change-Id: I0569534397a2d0db9587db6424b1674846a76079
ekalda
force-pushed
the
target-in-loopvectorizer
branch
from
8c95c41
to
acb0e74
Compare
lhutton1
approved these changes
Apr 19, 2024
|
Thanks @ekalda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that we are compiling for an SVE enabled target when the extent of a loop marked for vectorizing is a vscale dependent expression.
The extent of a loop should be either a positive integer or an vscale dependent expression, in the latter case we'd expect the target to have
has_svefeature.