Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fix incorrect doc in conv2d_nhwc_python #1677

Merged
merged 1 commit into from
Aug 30, 2018
Merged

[DOC] Fix incorrect doc in conv2d_nhwc_python #1677

merged 1 commit into from
Aug 30, 2018

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Aug 30, 2018

According to this, we expect the layout here to be HW channel_in channel_out
cc @masahi

masahi
masahi approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, that's correct

@yzhliu yzhliu merged commit 9f99a4f into apache:master Aug 30, 2018
@yzhliu
Copy link
Member

yzhliu commented Aug 30, 2018

Thanks @vinx13 @masahi

ZhennanQin pushed a commit to ZhennanQin/tvm that referenced this pull request Sep 6, 2018
@vinx13 @ZhennanQin
Fix incorrect doc in conv2d_nhwc_python (apache#1677)
3ab501a
FrozenGene pushed a commit to FrozenGene/tvm that referenced this pull request Dec 27, 2018
@vinx13 @yzhliu
Fix incorrect doc in conv2d_nhwc_python (apache#1677)
4e6740a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

@yzhliu yzhliu yzhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinx13 @yzhliu @masahi