Fix windows link error by expose the entry point for REGISTER_NODE_TYPE #1562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix issue #1547 , The original plan is to expose the dmlc::Registry::Get symbol in dmlc-core project, but later I found it does not work because nnvm is not only the consumer of dmlc::Registry symbol, but also need to enable registry on some new types, like:
DMLC_REGISTRY_ENABLE(nnvm::PassFunctionReg);
If we add MACRO like DMLC_DLL in registry.h, it will fail in nnvm because Windows does not allow to implement a function that declared as dllimport. I am currently use a workaround that in tvm lib, we expose another method that allow other component to access the dmlc::Registry<::tvm::NodeFactoryReg> instance, so nnvm could consume that one instead directly invoke the Get method in dmlc header file.
This is the simplest solution I can think of at this moment, but not sure does it align with tvm's design. Let me know if you have any concern.