Commits on Jul 12, 2023

1. [AOT] Avoid call_extern() with incorrect argument count …

   Prior to this commit, if device initialization is required, the AOT
   main function produced a `call_extern()` that included the device
   context as input.  This commit updates the AOT main function to
   provide the device context only if the function being called accepts a
   device context as input.
   
   If an extra device context argument is included at the call site, the
   C codegen would produce a function signature that includes the device
   context for the caller's compilation unit, but a signature without the
   device context for the callee's compilation unit.  While this can
   compile and run in some cases, it is undefined behavior for the
   signature to vary between compilation units, and should be avoided.
   
   This was initially discovered while debugging
   apache#14985, in which changes to the
   lowering flow resulted in the caller and callee being within the same
   compilation unit.

   

   Lunderberg committed Jul 12, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 3b5d135
   • Browse repository at this point

   Copy the full SHA

   3b5d135 View commit details

   Browse the repository at this point in the history