Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TensorIR][Visitor] Visit buffer members in match_buffer's in block visitor functions #15153

Merged
merged 8 commits into from
Jul 1, 2023

Conversation

yzh119
Copy link
Member

@yzh119 yzh119 commented Jun 24, 2023

Motivation

Currently, the elem_offset member in match_buffer's will not be visited in default block visitor functions, resulting in some passes cannot correctly rewrite the program because some fields have not been entered.

This PR fixes the issue by visiting this field in default StmtVisitor and StmtExpr.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jun 24, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: tensorir, visitor See #10317 for details

Generated by tvm-bot

@yzh119 yzh119 changed the title [TensorIR][Visitor] Visit buffer members in match_buffer's in block visitor functions. [TensorIR][Visitor] Visit buffer members in match_buffer's in block visitor functions Jun 24, 2023
@yzh119
Copy link
Member Author

yzh119 commented Jun 24, 2023

@tvm-bot rerun

@yzh119
Copy link
Member Author

yzh119 commented Jun 28, 2023

@tvm-bot rerun

@yzh119
Copy link
Member Author

yzh119 commented Jul 1, 2023

@tvm-bot rerun

@yzh119 yzh119 merged commit 34637d7 into apache:main Jul 1, 2023
5 checks passed
vinx13 added a commit to vinx13/tvm that referenced this pull request Sep 26, 2023
tqchen pushed a commit that referenced this pull request Sep 26, 2023
…in block visitor functions (#15153) (#15816)

* Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153)"
vinx13 added a commit to vinx13/tvm that referenced this pull request Oct 17, 2023
…in block visitor functions (apache#15153) (apache#15816)

* Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (apache#15153)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants