-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] Move SplitHostDevice to before MakePackedAPI #14986
[TIR] Move SplitHostDevice to before MakePackedAPI #14986
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
This PR is a subset of the changes introduced in #14862, split out for ease of testing and reviewing. It is currently a draft PR, as it interacts with the same functionality that is being fixed in #14982, and should probably re-run CI to avoid a similar breakage being reintroduced. While I've tested this PR against the specific VTA failure that is #14982 fixes, we may want to re-run CI on top of main to avoid similar breakage. |
b604e7b
to
4d1df64
Compare
This simplifies the logic used in MakePackedAPI, that it the last user of the host parameter in a function's target. After MakePackedAPI, every PrimFunc has a "target" attribute without a "host".
4d1df64
to
c31f2b0
Compare
@tvm-bot rerun (All CI tests passing, failure in CI/Windows due to a network connection dropping.) |
* [TIR] Move SplitHostDevice to before MakePackedAPI This simplifies the logic used in MakePackedAPI, that it the last user of the host parameter in a function's target. After MakePackedAPI, every PrimFunc has a "target" attribute without a "host". * Roofline plots, update location for SaveLoweredTIR * Update ethos-u tests to include host prior to MakeUnpackedAPI
This simplifies the logic used in MakePackedAPI, as it is now the last user of the host parameter in a function's target. After MakePackedAPI, every PrimFunc has a "target" attribute without a "host".
This is part of a series of commits to simplify the handling of multi-target builds.