Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Avoid symbol conflicts in MakePackedAPI/MakeUnpackedAPI #14950

Merged
merged 1 commit into from
May 25, 2023
Merged

[Bugfix] Avoid symbol conflicts in MakePackedAPI/MakeUnpackedAPI #14950

merged 1 commit into from
May 25, 2023

Commits on May 25, 2023

  1. [Bugfix] Avoid symbol conflicts in MakePackedAPI/MakeUnpackedAPI 

    PRs apache#14913 and
apache#14914 made analogous changes to
`MakePackedAPI` and `MakeUnpackedAPI` to handle subroutine calls.
Both PRs introduced the same symbol,
`tvm::tir::SubroutineCallRewriter`, a local utility to update internal
calls to a modified function.  While each PR passed CI individually,
and was therefore able to merge, having both changes caused a
duplicate symbol.

This commit updates `MakePackedAPI` and `MakeUnpackedAPI` to place
their local utilities into anonymous namespaces, avoiding the
conflict.
    @Lunderberg
    Lunderberg committed May 25, 2023
    Configuration menu
    Copy the full SHA
    65ac46a View commit details
    Browse the repository at this point in the history