[CONTRIB] Enable create_staticlib to take in tar files #14876
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
python/tvm/contrib/cc.py
Outdated
| temp = _utils.tempdir() | ||
| temp_output = temp.relpath(libname) | ||
| cmd = [ar, "-crs", temp_output] | ||
| objects = _tar.untar_files(temp, inputs) |
There was a problem hiding this comment.
I took a look in the implementation of untar_files and it is not clear to me why you need this function? From my point of view, you can use cmd += inputs.
Also, the second concern is that from the name of the function untar_files, I have concluded that it works with archives and extract files from it. But it is not clear, without reading the implementation of the function, how it works with list of non-tar files.
There was a problem hiding this comment.
Thanks for the comment, i changed to a longer name
This PR enahnces create_staticlib to take tar files which can be handy when combining multiple libs into a single a file.
|
@echuraev Let's get another round of review and get it in! |
This PR enahnces create_staticlib to take tar files which can be handy when combining multiple libs into a single a file.
This PR enahnces create_staticlib to take tar files which can be handy when combining multiple libs into a single a file.