Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMScript] Add __name__ attr for parsed PrimFunc and IRModule #14786

Merged
merged 1 commit into from
May 6, 2023

Conversation

Hzfengsy
Copy link
Member

@Hzfengsy Hzfengsy commented May 6, 2023

This PR adds __name__ attr to indicate the func/mod name for parsed PrimFunc and IRModule.

cc @tqchen @cyx-6

@tvm-bot
Copy link
Collaborator

tvm-bot commented May 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from cyx-6 and tqchen May 6, 2023 06:10
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Curious question: is the python-side attr going to affect the AST at all?

@Hzfengsy
Copy link
Member Author

Hzfengsy commented May 6, 2023

It will not affect the AST, just for a hint only in Python env for better UX :)

This PR adds `__name__` attr to indicate the func/mod name for parsed PrimFunc and IRModule.
@junrushao junrushao merged commit c265cda into apache:main May 6, 2023
@Hzfengsy Hzfengsy deleted the prim_func_name branch November 5, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants