[TIR] Improved parameter name in DLTensor unpacking error messages #14776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the parameter name depending only on the TIR variable name. In large IRModules, such as those used when executing end-to-end models, these parameter names may be resued across functions, and so the error message doesn't identify which `PrimFunc` should be investigated. This commit updates the parameter name to include the function name (e.g. `my_function.arg.my_param`) to help debugging in these cases.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the parameter name depending only on the TIR variable name. In large IRModules, such as those used when executing end-to-end models, these parameter names may be resued across functions, and so the error message doesn't identify which
PrimFuncshould be investigated.This commit updates the parameter name to include the function name (e.g.
my_function.arg.my_param) to help debugging in these cases.