[Relay] Handle pad value coming from Tensor instead of scalar #14735
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
1 similar comment
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
The PadCompute function would pass empty index to obtain the pad value.
This caused a crash when the pad value was given in a tensor with the
following message:
Check failed: shape.size() == indices.size() (1 vs. 0)
: Tensor dimension mismatch in read ndim = 1, indices.size=0
kparzysz-quic
force-pushed
the
pad-value-in-array
branch
from
32dc172
to
ad58d81
Compare
| # This used to crash | ||
|
|
||
|
|
||
| def test_pad_value_in_array(): |
There was a problem hiding this comment.
Please move this test to tests/python/relay/test_op_level2.py where there are existing tests for nn.pad.
kparzysz-quic
force-pushed
the
pad-value-in-array
branch
from
d3f751c
to
cb3fb1d
Compare
|
@tvm-bot rerun |
1 similar comment
|
@tvm-bot rerun |
|
@driazati Do you know why docker/pr-head is marked as "failed", but when I click on "details", there is no indication of a failure there? Edit: The failure marking is gone now. I'm not sure what happened. |
I'm not quite sure myself, the full log: https://ci.tlcpack.ai/job/tvm-docker/job/PR-14735/5/console looks like everything completed successfully but the job says it was cancelled/interrupted (rather than a regular failure). |
I think what's happening is that there are several builds running for this PR at the same time, and the latest one to finish notifies the status page. The wasm build was "failed" for a while, and now it's set to "passed". |
The PadCompute function would pass empty index to obtain the pad value. This caused a crash when the pad value was given in a tensor with the following message: