-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] Enhance TVMScript Buffer Slice Access #14693
[TIR] Enhance TVMScript Buffer Slice Access #14693
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
cc @cyx-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have problem with the fix per se, but was thinking if this ad-hoc fix is sufficient. To be more precise, vectorized buffer access being recognized as PrimExpr instead of BufferRegion.
Thanks @lightzhan-intellif for the fix! I think it would be good to also test that the scripted output of |
Thanks for your suggestion, I will have a look. |
This PR tries to fix a bug, which will case the error:
The problem will occur when it is a binary operation between two BufferSlice accesses, because the parser do not know how to deal with it.
This PR solves this by adding corresponding ops to
BufferRegion
. Any further suggestion is welcomed!@junrushao @Hzfengsy @wrongtest-intellif