[LLVM] Use Var annotation in LetStmt for pointer type #14570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIR has type-annotations on variables, but not on each PrimExpr. Because some versions of LLVM (before LLVM 15) default to using typed pointers, passing LLVM validation may require correct pointer types. This is typically encountered in unpacking of PackedFunc arguments, where the LLVM type of a data array must be cast from `i8*` to a pointer to the buffer type. These pointer-to-pointer casts are not expressible in TIR, because the `tir::CastNode` represents all pointers as `DataType::Handle()`, and so must be handled during codegen instead of earlier in the lowering flow.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
kparzysz-quic
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIR has type-annotations on variables, but not on each PrimExpr. Because some versions of LLVM (before LLVM 15) default to using typed pointers, passing LLVM validation may require correct pointer types. This is typically encountered in unpacking of PackedFunc arguments, where the LLVM type of a data array must be cast from
i8*to a pointer to the buffer type. These pointer-to-pointer casts are not expressible in TIR, because thetir::CastNoderepresents all pointers asDataType::Handle(), and so must be handled during codegen instead of earlier in the lowering flow.