[TIR] Flatten SeqStmt on construction #14492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, SeqStmt could be nested, making a distinction between the
nested `SeqStmt({SeqStmt({a,b}), c})` and the flat `SeqStmt({a,b,c})`,
even though the two are semantically equivalent. This also caused an
issue with round-trips through TVMScript, which does not preserve this
distinction.
This commit updates the `SeqStmt` constructor and the `SeqStmt`
visitor in `StmtMutator` to flatten nested sequential statements
provided.
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
The flattening still can produce ambiguous structure for `SeqStmt` of size 0 and 1. Normalizing so that `SeqStmt::Flatten` will automatically unwrap when flattening produces a single statement, and will convert to `Evaluate(0)` when flattening removes all statements.
Hzfengsy
approved these changes
Apr 5, 2023
If neither flattening nor unwrapping is required, the returned SeqStmt should be the same object as the argument.
Otherwise, the SeqStmt removes the "Evaluate(0)" before we can get to the part that we want to test.
Lunderberg
force-pushed
the
flatten_seqstmt
branch
from
8be5885
to
a5eff13
Compare
|
Sorry for the late response. Could you please rebase it again and let's merge it? |
|
No worries (this has been on my back burner as well). Main has been merged into the PR branch to resolve conflicts, and now running through CI. |
|
@tvm-bot rerun |
|
Thanks @Lunderberg for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SeqStmt could be nested, making a distinction between the nested
SeqStmt({SeqStmt({a,b}), c})and the flatSeqStmt({a,b,c}), even though the two are semantically equivalent. This also caused an issue with round-trips through TVMScript, which does not preserve this distinction.This commit updates the
SeqStmtconstructor and theSeqStmtvisitor inStmtMutatorto flatten nested sequential statements provided.This is part of changes described in #14486, to improve round-trip failures that occur in lowering.