Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update ci_cpu image and build with llvm-15 #14466

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

multiverstack-intellif
Copy link
Contributor

@multiverstack-intellif multiverstack-intellif commented Apr 3, 2023

Update docker image tag as a follow up step for #14303.

cc @Hzfengsy @wrongtest-intellif @elvin-n

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 3, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@lhutton1
Copy link
Contributor

lhutton1 commented Apr 4, 2023

Thanks @multiverstack-intellif, it seems the correct tlcpackstaging image was pulled successfully, but there seems to be an sccache error I'm a little unsure about - I'll retrigger to see if it is transient

@lhutton1
Copy link
Contributor

lhutton1 commented Apr 4, 2023

@tvm-bot rerun

@multiverstack-intellif
Copy link
Contributor Author

Thanks @lhutton1 , it seems it keeps failing with the same error: "sccache: error: Timed out waiting for server startup." @driazati If possible, could you please help us on this or give any kind of clue? Thanks very much.

@driazati
Copy link
Member

driazati commented Apr 5, 2023

The error is pretty repeatable in CI which maybe indicates that something is wrong with the new image, it might be worthwhile to see if this replicates locally to determine if it's an issue with the CI machines or the image. I'm not too sure about the particular error though, maybe updating sccache to 0.4.1 (the latest release) would help?

@lhutton1
Copy link
Contributor

lhutton1 commented Apr 6, 2023

Thanks for the suggestions @driazati, I tested this locally and can confirm the issue. I've bisected the failure to between:

tlcpackstaging/ci_cpu:20230321-064144-48193008 -- working (sccache version: 0.3.3)
tlcpackstaging/ci_cpu:20230322-060120-46fb2ff35 -- timeout failure (sccache version: 0.4.0)

Note the difference in sccache version.

I wasn't able to get any further before the holidays (back on the 11th Apr), perhaps we can pin to v0.3.3 for now?

@driazati
Copy link
Member

driazati commented Apr 6, 2023

Thanks for the suggestions @driazati, I tested this locally and can confirm the issue. I've bisected the failure to between:

tlcpackstaging/ci_cpu:20230321-064144-48193008 -- working (sccache version: 0.3.3)
tlcpackstaging/ci_cpu:20230322-060120-46fb2ff35 -- timeout failure (sccache version: 0.4.0)

Note the difference in sccache version.

I wasn't able to get any further before the holidays (back on the 11th Apr), perhaps we can pin to v0.3.3 for now?

Pinning to 3.3 sounds fine with me

@multiverstack-intellif
Copy link
Contributor Author

multiverstack-intellif commented Apr 10, 2023

A test case seems need modification, llvm-15 emits pmaddwd instead of pmulhw in this case, @elvin-n please help review if the change to this case is OK, thanks very much.

@multiverstack-intellif multiverstack-intellif marked this pull request as ready for review April 10, 2023 03:08
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junrushao junrushao merged commit a7a1980 into apache:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants