Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetaSchedule][Testing] Migrate Add-RFactor to use SEqual #12758

Merged

Conversation

junrushao
Copy link
Member

@junrushao junrushao commented Sep 12, 2022

This PR migrates the usage of check_trace to check_sketch,
which prefers structural equality of TIRs insteda of string equalty
of traces.

cc @Hzfengsy @junrushao1994

@junrushao junrushao marked this pull request as ready for review September 12, 2022 20:22
@junrushao
Copy link
Member Author

junrushao commented Sep 12, 2022

CC: @vinx13 @Hzfengsy @jinhongyii

@junrushao junrushao force-pushed the feature/2022-09-12/migrate-add-rfactor branch from 5bfb8f1 to 5279d13 Compare September 12, 2022 20:43
This PR migrates the usage of `check_trace` to `check_sketch`,
which prefers structural equality of TIRs insteda of string equalty
of traces.
@junrushao junrushao force-pushed the feature/2022-09-12/migrate-add-rfactor branch from 5279d13 to 49b92a8 Compare September 12, 2022 20:59
Copy link
Contributor

@jinhongyii jinhongyii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junrushao junrushao merged commit a23b71c into apache:main Sep 12, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This PR migrates the usage of `check_trace` to `check_sketch`,
which prefers structural equality of TIRs insteda of string equalty
of traces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants