Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIR] Implement API for padded layout transformations #12720

Merged
merged 27 commits into from
Sep 19, 2022
Merged

[TIR] Implement API for padded layout transformations #12720

merged 27 commits into from
Sep 19, 2022

Commits on Sep 6, 2022

  1. [UnitTests] Initial unit tests for padded transformation behavior

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    93559cf View commit details
    Browse the repository at this point in the history

  2. [Utils][Fix] Correction for non-empty Callable type annotations

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    60ea527 View commit details
    Browse the repository at this point in the history

  3. [TIR] Pass the pad_value argument from Python to C++

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2971b5b View commit details
    Browse the repository at this point in the history

  4. [TIR] Added check to validate lack of transformation padding

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    885fd78 View commit details
    Browse the repository at this point in the history

  5. Raise error if pad value doesn't match buffer's data type.

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    185eead View commit details
    Browse the repository at this point in the history

  6. Simplify expresions in IndexMap::NonsurjectiveInverse

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    874bfc2 View commit details
    Browse the repository at this point in the history

  7. Preparatory refactor, update BlockNode::alloc_buffers while visiting

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ddea093 View commit details
    Browse the repository at this point in the history

  8. Introduced LayoutTransformPlanner for planning how to pad

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    2055bbf View commit details
    Browse the repository at this point in the history

  9. Implemented insertion of T.assume for input buffers

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f3538cd View commit details
    Browse the repository at this point in the history

  10. Implement epilogue plan for explicitly setting pad value

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a6dbd30 View commit details
    Browse the repository at this point in the history

  11. Check LetStmt bindings when determining loop dependencies

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    619c5b7 View commit details
    Browse the repository at this point in the history

  12. Implement replacement plan for using tir::if_then_else 

    For producer blocks that iterate over the pre-transformation shape,
rewrite to iterate over the post-transformation shape, with
`tir::if_then_else` to handle writing to indices corresponding to
padding/non-padding.
    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    aa9bbf7 View commit details
    Browse the repository at this point in the history

  13. Removed development-only unit test

    @Lunderberg
    Lunderberg committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7f5707c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Add default value of NullOpt for pad_value

    @Lunderberg
    Lunderberg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5a1e63f View commit details
    Browse the repository at this point in the history

  2. Removed debug code

    @Lunderberg
    Lunderberg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c463043 View commit details
    Browse the repository at this point in the history

  3. Update unit tests to use non-opaque blocks 

    Unless specifically testing opaque blocks, all unit tests for the
transform layout scheduling primitive now operate on non-opaque
blocks.
    @Lunderberg
    Lunderberg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    98a8446 View commit details
    Browse the repository at this point in the history

  4. Resolve linting error

    @Lunderberg
    Lunderberg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    19af1ee View commit details
    Browse the repository at this point in the history

  5. Removed iter_var usage from T.where clauses

    @Lunderberg
    Lunderberg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8eb775a View commit details
    Browse the repository at this point in the history

  6. Improve docstring on pad_value 

    Specifically calling attention to how `pad_value` interacts with input
buffers, that correctness depends on the calling scope providing the
specified `pad_value`.
    @Lunderberg
    Lunderberg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e874020 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Documentation for TransformLayoutPlanner, rename for consistency 

    The previous name `LayoutTransformPlanner` didn't follow the pattern
of `TransformLayoutWriter`.  Therefore, renaming to
`TransformLayoutPlanner`.
    @Lunderberg
    Lunderberg committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    6386db5 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Updated C++ API to take IndexMap as input

    @Lunderberg
    Lunderberg committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    59a0acf View commit details
    Browse the repository at this point in the history

  2. Update expected trace in multi-level tiling tests

    @Lunderberg
    Lunderberg committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    d532610 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Update shared_32x16_to_ldmatrix_32x16_layout to be injective 

    Previous version mapped the 512 input indices in a `(32,16)` array to
only 128 output indices.  This wasn't caught before, because the
bijectivity assertion was only triggered for TE schedules.
    @Lunderberg
    Lunderberg committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    efb25ac View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Updated IndexMap docstrings for single PrimExpr returns

    @Lunderberg
    Lunderberg committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    13b8cef View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Updated docstring for valid pad values, validate

    @Lunderberg
    Lunderberg committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    19a78e8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into padded_layout_api

    @Lunderberg
    Lunderberg committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    d801dab View commit details
    Browse the repository at this point in the history

  3. Fix lint error

    @Lunderberg
    Lunderberg committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    6a4f4cc View commit details
    Browse the repository at this point in the history