Add methods to get and set late-bound constants. #12664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rkimball, this overall looks like a solid change. The one thing I'd like to see is the addition of some tests to make sure this works as expected. |
|
Thank you Josh. I added some tests. Much of this new code is already tested as it is an integral part of the normal save/load. I added tests for the new API functions. |
jwfromm
approved these changes
Aug 31, 2022
|
This is now merged, thanks @rkimball! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* Add methods to read and restore late-bound constants on Executable. * Add bindings for new functions * Cleanup * Fix function name * Add tests for python API to access new load/save functions * Add another tests for python API to access new load/save functions where there are no constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods to both get and set late-bound constants.
The current approach for saving and restoring a model's late-bound constants is via the either
MoveLateBoundConstantsToFileand then this file can be reloaded to the Executable by callingLoadLateBoundConstantsFromFile. These methods save the constants to a fileconsts.I have a need to save and restore the constants in a pre-existing format. In order to write these I added
GetLateBoundConstantswhich returns a Map of all late-bound contants. To restore the constants back to the ExecutableLoadLateBoundConstantsFromMapwas added.The PR arranges the code so that both
GetLateBoundConstantsandLoadLateBoundConstantsFromMapare used in the existing methods to write and read late-bound constants. This means there is minimal code change, functions were mostly just rearranged to expose the two new entry points.