Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace '> >' in templates with >>, NFC #12615

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Replace '> >' in templates with >>, NFC #12615

merged 1 commit into from
Aug 26, 2022

Conversation

kparzysz-quic
Copy link
Contributor

The problem with greedy lexing of >> as an operator was solved in C++11, and now templates no longer require spaces between >'s.

The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kparzysz-quic kparzysz-quic merged commit 23e7944 into apache:main Aug 26, 2022
@kparzysz-quic kparzysz-quic deleted the template-closing-brackets branch August 26, 2022 20:59
driazati pushed a commit to driazati/tvm that referenced this pull request Aug 26, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Aug 26, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Aug 29, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Aug 30, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Sep 1, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Sep 1, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Sep 6, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
driazati pushed a commit to driazati/tvm that referenced this pull request Sep 6, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
areusch pushed a commit that referenced this pull request Sep 7, 2022
Replace '> >' in templates with >>, NFC (#12615)

The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.

Co-authored-by: Krzysztof Parzyszek <kparzysz@quicinc.com>
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Replace '> >' in templates with >>, NFC (apache#12615)

The problem with greedy lexing of >> as an operator was solved in
C++11, and now templates no longer require spaces between >'s.

Co-authored-by: Krzysztof Parzyszek <kparzysz@quicinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants