[TOPI][Bugfix] Make semantics of empty axis
in squeeze
consistent with Relay
#12596
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11697. The analysis of the bug is elaborated in #12400. The key problem is whether
axis
insqueeze
means doing nothing or squeezing all one-dimensional axes.In #12400, I provide two possible fixes. I choose to fix TOPI finally. The meaning of
axis
is clearly described here (commit #2020):tvm/include/tvm/relay/attrs/transform.h
Lines 319 to 327 in fb7cf97
The later commit to TOPI (#2147), however, does not follow this description. It seems that there is a mistake in this commit and should be corrected.
CC: @masahi