[ONNX] Fix test to disable default ONNX frontend constant folding #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TVM ONNX frontend, constants are folded by default, which makes test_load_model__onnx to fail because it is looking for "params" that were already converted into constants. This patch fixes the test to disable constant folding so that we can assert that "params" in the model are present as expected. Change-Id: Ifa5aefa3bbafcd85e383e1292f57b479bdf28c8b
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…ache#12532) In TVM ONNX frontend, constants are folded by default, which makes `test_load_model__onnx` to fail because it is looking for "params" that were already converted into constants. This patch fixes the test to disable constant folding so that we can assert that "params" in the model are present as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TVM ONNX frontend, constants are folded by default, which makes
test_load_model__onnxto fail because it is looking for "params" that were already converted into constants.This patch fixes the test to disable constant folding so that we can assert that "params" in the model are present as expected.
cc @ashutosh-arm @driazati @areusch @Mousius @NicolaLancellotti