Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMScript] Printer: add boolean operators to OperationDoc #12518

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

yelite
Copy link
Contributor

@yelite yelite commented Aug 21, 2022

This PR adds boolean operators to OperationDoc. This is needed by the TIR expression printing because it has tir::And and tir::Or.

Tracking issue: #11912

cc @junrushao1994

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for also testing the operator precedence!

@junrushao junrushao merged commit 2629065 into apache:main Aug 22, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
)

This PR adds boolean operators to OperationDoc. This is needed by the TIR expression printing because it has `tir::And` and `tir::Or`.

Tracking issue: apache#11912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants