-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Set USE_CMSISNN and USE_ETHOSU off in task_config_build_cpu.sh #12456
Conversation
cc @leandron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the flags here are not tested in a context of ci_cpu
, and are covered by the https://github.com/apache/tvm/blob/main/tests/scripts/task_config_build_cortexm.sh setup, where they are properly tested.
LGTM
thanks @ekalda ! looks like we are still running one of those tests in CPU somehow, maybe need to make sure that one got moved to arm and then remove it from CPU. |
Hi @areusch , sorry I've had very busy last few days, but I'm on it now - I looked into this and the problem is that we still install Vela in ci_cpu (https://github.com/apache/tvm/blob/main/docker/Dockerfile.ci_cpu#L129) despite moving Ethos-U into ci_cortexm and we use the presence of Vela as a proxy when deciding whether to run a test or not if it is outside of So I think I'll park this change for a bit and propose a docker image change and once that is done, we should be able to merge this twoliner patch :) |
@tvm-bot rerun |
The dependencies for these have moved into ci_cortexm Docker image, so there is not much point in building them for ci_cpu as we can't run the associated tests.
a08f3b2
to
3a6572b
Compare
…pache#12456) The dependencies for these have moved into ci_cortexm Docker image, so there is not much point in building them for ci_cpu as we can't run the associated tests.
The dependencies for these have moved into ci_cortexm Docker
image, so there is not much point in building them for ci_cpu as we
can't run the associated tests.
cc @Mousius @areusch @driazati @gigiblender