[Target] Remove deprecated parameters from target

[mehrdadh]

fixes #12409

cc @areusch @Mousius

[Mousius]

We should probably keep using pytest.mark.parametrize to aid in linting this file.

[mehrdadh]

done

[Mousius]

This is pretty complex, would be better to have test_target and unsupported_config in a tuple.

[mehrdadh]

done.

[areusch]

thanks @mehrdadh, broadly looks good but we should check on system-lib, because that changes the way code is loaded on the target.

[areusch]

i think we need to keep --system-lib passed to Executor config here. can you audit the other places you removed --system-lib and ensure the Executor passed to relay.build has it?

[mehrdadh]

I double checked places that I removed and added to the executor as needed. Please let me know if I missed anything

[mehrdadh]

@Mousius PTAL, thanks!

[Mousius]

LGTM! The failing test seems unrelated, thanks for picking this up @mehrdadh 😸

[masahi]

So --link-params=1 in target is deprecated now? I am about to send a PR that depends on link-params option in target...

What I'm going to do is to fix the behavior of FuseOps and meta schedule task extraction when link-params = 1.
The issue is that FuseOps looks up link-params from Executor here

tvm/src/relay/transforms/fuse_ops.cc

Lines 1054 to 1056 in 111169c

	link_params = executor.defined()
	? executor->attrs.GetAttr<Bool>("link-params").value_or(Bool(link_params))
	: link_params;

while FuseOps can be called from a context where there is no executor. One of such places is meta schedule task extraction,

tvm/src/relay/backend/task_extraction.cc

Line 44 in ecfd969

pass_seqs.push_back(transform::FuseOps());

.

FuseOps thinks link-params is False when it is called by task extraction, while when called from relay.build(..., executor), it sees that link-params is True. So subgraphs extracted by task extraction would never match those that are actually generated during relay.build when link-params is True.

My fix is to look up link-params option from target and enable relay.FuseOps.link_params, before calling FuseOps from task extraction.
https://github.com/masahi/tvm/blob/f1f395cb66ba6d3b6fe488b6dda376e33f51b8e4/src/relay/backend/task_extraction.cc#L47-L52

if link-params option in target is deprecated, I need to thread through executor in task extraction, which will cause some breaking API changes.

[areusch]

@masahi I see...I think perhaps we might need to arrange to thread the Executor through. at the moment the way we model memory in the compiler doesn't guarantee that Constant will wind up in any particular location, so link-params is mainly an executor-level thing. what do you think? the change that caused this was also a relay.build API change as well.

[masahi]

@areusch Since most common use cases do not need link-params, I hesitate to break API and impose executor argument to all users of meta schedule task extraction. Instead, I'm leaning toward pushing the responsibility to users if they want to use link-params together with meta schedule, by requiring the following usage:

    with tvm.transform.PassContext(config={"relay.FuseOps.link_params": 1}):
         meta_schedule.extract_task_from_relay(...)