Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnitTest][TIR] Testing utility for before/after transform tests #12264

Merged
merged 3 commits into from
Aug 2, 2022

Conversation

Lunderberg
Copy link
Contributor

This PR adds tvm.testing.CompareBeforeAfter, a generalization of the BaseBeforeAfter utility previously used in test_tir_transform_simplify.py, which performs unit tests that perform a transformation on a TIR function and compare the results to an expected TIR output. This arose when minimizing the boilerplate required for unit tests in the implementation of #12261.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very cool improvement over the existing test infra! Thanks for making this happen!

@junrushao junrushao merged commit bca0385 into apache:main Aug 2, 2022
@Lunderberg Lunderberg deleted the testing_before_after branch August 2, 2022 15:09
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Sep 27, 2022
A follow-up commit from apache#12264.
This allows the before/expected fixtures generated by
`tvm.testing.CompareBeforeAfter` to be `IRModule` instances as well as
`PrimFunc`.  This is intended to allow testing that requires comparing
more than one function (e.g. hoisting/fusing a PrimFunc).
csullivan pushed a commit that referenced this pull request Oct 7, 2022
…12920)

A follow-up commit from #12264.
This allows the before/expected fixtures generated by
`tvm.testing.CompareBeforeAfter` to be `IRModule` instances as well as
`PrimFunc`.  This is intended to allow testing that requires comparing
more than one function (e.g. hoisting/fusing a PrimFunc).

* Prevent circular fixture references
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…che#12264)

This PR adds `tvm.testing.CompareBeforeAfter`, a generalization of the `BaseBeforeAfter` utility previously used in `test_tir_transform_simplify.py`, which performs unit tests that perform a transformation on a TIR function and compare the results to an expected TIR output.  This arose when minimizing the boilerplate required for unit tests in the implementation of apache#12261.
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…pache#12920)

A follow-up commit from apache#12264.
This allows the before/expected fixtures generated by
`tvm.testing.CompareBeforeAfter` to be `IRModule` instances as well as
`PrimFunc`.  This is intended to allow testing that requires comparing
more than one function (e.g. hoisting/fusing a PrimFunc).

* Prevent circular fixture references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants