[TVMScript] StmtDoc Definitions #12111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2022
Closed
yelite
force-pushed
the
tunip-stmt-doc-def
branch
2 times, most recently
from
550731e
to
bcd2520
Compare
yelite
force-pushed
the
tunip-stmt-doc-def
branch
from
e42741d
to
d2f328c
Compare
This PR addes: - All StmtDoc subclasses - Python bindings for StmtDoc Tracking issue: apache#11912
junrushao
force-pushed
the
tunip-stmt-doc-def
branch
from
d2f328c
to
0605028
Compare
junrushao
reviewed
Jul 27, 2022
| @@ -219,6 +292,7 @@ class IdDoc : public ExprDoc { | |||
| * \param name The name of identifier. | |||
| */ | |||
| explicit IdDoc(String name); | |||
| explicit IdDoc(std::nullptr_t) : ExprDoc(nullptr) {} | |||
There was a problem hiding this comment.
Yeah this is a good idea to explicitly define constructor with std::nullptr_t so that the compiler could distinguish between nullptr -> const char* -> String and nullptr -> ObjectPtr
junrushao
reviewed
Jul 27, 2022
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
This PR addes: - All StmtDoc subclasses - Python bindings for StmtDoc Tracking issue: apache#11912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addes:
Tracking issue: #11912
cc @junrushao1994 @gbonik