[Collage] CollagePartition pass #12086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbaret here's the big one! |
See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. This adds the main CollagePartition pass, which: 1. Inspects all the targets in the CompilationConfig and builds PartitionSpecs describing how to generate speculative CandidatePartitions for them. 2. Runs the above rules on the model to collect all the candidates. 3. Eliminates candidates whose target contradicts any constraints already imposed by, eg, device planning. 4. Eagerly estimates the cost of each candidate. 5. Performs a shortest path search to chose an 'optimal' set of candidate partitions so as to minimize estimated model latency, such that every sub-expression node is contained in exactly one candidate partition. 6. Coalesces adjacent optimal candidates which ended up on the same target. 7. Rewrites the model according to the chosen optimal partitioning. As for the existing partition_for_<external codegen name> methods, the result of CollagePartition can then be built using regular TVM. Very special thanks to @mbaret for authoring test_pass_collage_partition.py. Logic to prune the candidates after step 3 will be in a follow up PR since it deserves its own testing. A demonstration driver will also come as a follow up.
mbs-octoml
force-pushed
the
mbs-collage-partitioner
branch
from
96631de
to
5fcbe37
Compare
|
Rebased onto main. |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [Collage] CollagePartition pass See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. This adds the main CollagePartition pass, which: 1. Inspects all the targets in the CompilationConfig and builds PartitionSpecs describing how to generate speculative CandidatePartitions for them. 2. Runs the above rules on the model to collect all the candidates. 3. Eliminates candidates whose target contradicts any constraints already imposed by, eg, device planning. 4. Eagerly estimates the cost of each candidate. 5. Performs a shortest path search to chose an 'optimal' set of candidate partitions so as to minimize estimated model latency, such that every sub-expression node is contained in exactly one candidate partition. 6. Coalesces adjacent optimal candidates which ended up on the same target. 7. Rewrites the model according to the chosen optimal partitioning. As for the existing partition_for_<external codegen name> methods, the result of CollagePartition can then be built using regular TVM. Very special thanks to @mbaret for authoring test_pass_collage_partition.py. Logic to prune the candidates after step 3 will be in a follow up PR since it deserves its own testing. A demonstration driver will also come as a follow up. * - lints * - more lints * - use the _ffi_api properly
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [Collage] CollagePartition pass See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md. This adds the main CollagePartition pass, which: 1. Inspects all the targets in the CompilationConfig and builds PartitionSpecs describing how to generate speculative CandidatePartitions for them. 2. Runs the above rules on the model to collect all the candidates. 3. Eliminates candidates whose target contradicts any constraints already imposed by, eg, device planning. 4. Eagerly estimates the cost of each candidate. 5. Performs a shortest path search to chose an 'optimal' set of candidate partitions so as to minimize estimated model latency, such that every sub-expression node is contained in exactly one candidate partition. 6. Coalesces adjacent optimal candidates which ended up on the same target. 7. Rewrites the model according to the chosen optimal partitioning. As for the existing partition_for_<external codegen name> methods, the result of CollagePartition can then be built using regular TVM. Very special thanks to @mbaret for authoring test_pass_collage_partition.py. Logic to prune the candidates after step 3 will be in a follow up PR since it deserves its own testing. A demonstration driver will also come as a follow up. * - lints * - more lints * - use the _ffi_api properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/apache/tvm-rfcs/blob/main/rfcs/0062-collage.md.
This adds the main CollagePartition pass, which:
PartitionSpecs describing how to generate speculative CandidatePartitions
for them.
imposed by, eg, device planning.
partitions so as to minimize estimated model latency, such that every sub-expression
node is contained in exactly one candidate partition.
As for the existing partition_for_ methods, the result of
CollagePartition can then be built using regular TVM.
Very special thanks to @mbaret for authoring test_pass_collage_partition.py.
Logic to prune the candidates after step 3 will be in a follow up PR since it
deserves its own testing. A demonstration driver will also come as a follow up.