Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise #12006

Merged
merged 3 commits into from
Jul 11, 2022
Merged

[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise #12006

merged 3 commits into from
Jul 11, 2022

Conversation

ashutosh-arm
Copy link
Contributor

@ashutosh-arm ashutosh-arm commented Jul 4, 2022 •
edited by github-actions bot
Loading

This commit converts Relay Conv2D into depthwise
convolution. This is done only when total number
of output channels can be derived using the depth
multiplier. The tests include special case of output
channels=1.

cc @areusch

@ashutosh-arm
[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise
ebb7408 
Change-Id: I49cd262ce057b2a314f56aadca9b12995a519e88
@ashutosh-arm
Included Depthwise CMSIS-NN sources in zephyr demo
fea574b 
Change-Id: Ieace94bd0f29d92660bd8e3a2523c1bf42b6afaa
@github-actions github-actions bot requested a review from areusch July 5, 2022 09:41
@ashutosh-arm
Copy link
Contributor Author

cc @manupa-arm @Mousius @grant-arm for code review.

Mousius
Mousius requested changes Jul 6, 2022
View reviewed changes
src/relay/backend/contrib/cmsisnn/relay_to_tir.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/utils.cc Outdated Show resolved Hide resolved
src/relay/backend/contrib/cmsisnn/utils.cc Outdated Show resolved Hide resolved
tests/python/contrib/test_cmsisnn/test_conv2d.py Show resolved Hide resolved
@ashutosh-arm
C style function naming and additional check around Depthwise CMSIS-N…
7a0c89f 
…N API

Change-Id: Iec889ea4d2989617c085803aa9e72eb3296f2d35
Mousius
Mousius approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool @ashutosh-arm 😸

@Mousius Mousius merged commit b4c1cc0 into apache:main Jul 11, 2022
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
@ashutosh-arm @masahi
[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise (apac…
07fd4e4 
…he#12006)
junrushao pushed a commit to yelite/tvm that referenced this pull request Jul 27, 2022
@ashutosh-arm @junrushao
[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise (apac…
56f72eb 
…he#12006)
@ashutosh-arm ashutosh-arm deleted the replace_conv2d_with_depthwise branch August 31, 2022 11:31
@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@ashutosh-arm @xinetzone
[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise (apac…
bfa07c3 
…he#12006)
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
@ashutosh-arm
[CMSIS-NN][Perf] Converted Relay Conv2D into CMSIS-NN Depthwise (apac…
5a82893 
…he#12006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mousius Mousius Mousius approved these changes

@areusch areusch Awaiting requested review from areusch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashutosh-arm @Mousius