Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI] [Hexagon] Reshape slice op #11983

Merged
merged 4 commits into from
Jul 7, 2022
Merged

[TOPI] [Hexagon] Reshape slice op #11983

merged 4 commits into from
Jul 7, 2022

Conversation

abhikran-quic
Copy link
Contributor

@abhikran-quic abhikran-quic commented Jul 1, 2022 •
edited by github-actions bot
Loading

  • This patch adds the initial python implementation reshape slice op for hexagon.
  • The test infrastructure of batch_flatten is reused here since batch_flatten is a special case of reshape. Hence tests of batch_flatten op are moved to test_reshape.py

cc @mehrdadh

@abhikran-quic
Copy link
Contributor Author

Hi @Lunderberg, @cconvey and @mehrdadh : Could you please review this PR ?

@abhikran-quic abhikran-quic changed the title Reshape slice op [Hexagon] Reshape slice op Jul 1, 2022
@abhikran-quic abhikran-quic changed the title [Hexagon] Reshape slice op [TOPI] [Hexagon] Reshape slice op Jul 5, 2022
@abhikran-quic
Copy link
Contributor Author

@Lunderberg, @cconvey and @mehrdadh : Could you please review this PR ?

mehrdadh
mehrdadh approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@mehrdadh mehrdadh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhikran-quic
Copy link
Contributor Author

Thank you @mehrdadh for approving the PR. Could you please help in merging the PR as well ?

@mehrdadh mehrdadh merged commit c76d8e2 into apache:main Jul 7, 2022
@abhikran-quic abhikran-quic deleted the reshape_slice_op branch July 7, 2022 18:22
masahi pushed a commit to masahi/tvm that referenced this pull request Jul 15, 2022
@abhikran-quic @masahi
[TOPI] [Hexagon] Reshape slice op (apache#11983)
4734932 
* Reshape slice op. This patch adds the initial python implementation reshape slice op for hexagon.

* Add tests for reshape op
@AndrewZhaoLuo AndrewZhaoLuo mentioned this pull request Oct 4, 2022
Closed
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
@abhikran-quic
[TOPI] [Hexagon] Reshape slice op (apache#11983)
576c764 
* Reshape slice op. This patch adds the initial python implementation reshape slice op for hexagon.

* Add tests for reshape op
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehrdadh mehrdadh mehrdadh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhikran-quic @mehrdadh