[TIR] Improved error message if tir.Schedule passed to lower/build #11913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a TIR Schedule is passed to `tvm.lower`, the error
message is returned `ValueError: ('Expected input to be an IRModule,
PrimFunc or Schedule, but got, ', <class
'tvm.tir.schedule.schedule.Schedule'>)`. This can cause user
confusion, as the expected class name in the error message does not
differentiate between between a `tvm.te.Schedule` and a
`tvm.tir.Schedule`. Updated error message to explicitly state that
this should be a `te.Schedule`.
|
@tvm-bot rerun |
junrushao
approved these changes
Jun 27, 2022
|
Thanks @Lunderberg!! |
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
…pache#11913) Previously, if a TIR Schedule is passed to `tvm.lower`, the error message is returned `ValueError: ('Expected input to be an IRModule, PrimFunc or Schedule, but got, ', <class 'tvm.tir.schedule.schedule.Schedule'>)`. This can cause user confusion, as the expected class name in the error message does not differentiate between between a `tvm.te.Schedule` and a `tvm.tir.Schedule`. Updated error message to explicitly state that this should be a `te.Schedule`.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…pache#11913) Previously, if a TIR Schedule is passed to `tvm.lower`, the error message is returned `ValueError: ('Expected input to be an IRModule, PrimFunc or Schedule, but got, ', <class 'tvm.tir.schedule.schedule.Schedule'>)`. This can cause user confusion, as the expected class name in the error message does not differentiate between between a `tvm.te.Schedule` and a `tvm.tir.Schedule`. Updated error message to explicitly state that this should be a `te.Schedule`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a TIR Schedule is passed to
tvm.lower, the error message is returnedValueError: ('Expected input to be an IRModule, PrimFunc or Schedule, but got, ', <class 'tvm.tir.schedule.schedule.Schedule'>). This can cause user confusion, as the expected class name in the error message does not differentiate between between atvm.te.Scheduleand atvm.tir.Schedule. Updated error message to explicitly state that this should be ate.Schedule.