Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Texture] Add 2d memory support into static memory planner #11876

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

elvin-n
Copy link
Contributor

@elvin-n elvin-n commented Jun 24, 2022

Co-authored-by: Chris Sullivan csullivan@octoml.ai

This PR is a split part of origin PR11357
@csullivan @mbs-octoml

@TejashShah
Copy link

@csullivan @masahi @mbs-octoml Please review and push this PR through.

@masahi
Copy link
Member

masahi commented Jul 11, 2022

@elvin-n Can you add tests?

Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to the graph memory planner originate back from #7690. Given that I was the author of that PR and many of these changes, I don't feel comfortable merging this without additional reviews but the change looks good to me if others feel that refactor the graph memory planner in this way is acceptable.

Ultimately in Relax graph-tir memory planning will be unified and texture can be represented as an Nd Buffer, and a separate pass can handle memory planning based on a target specific handling for Nd memory. Given that I'm personally okay with this change landing as even though it is fairly specific, we don't intend for the graph executor memory planner to be any more generically useful for Nd memory down the road.

Edit: As @masahi pointed out, it would be useful to have some unit tests of the 2d planner.

@elvin-n elvin-n force-pushed the amalyshe/texture_static_mplanner branch from 3cf99ab to 9eab9b2 Compare July 18, 2022 09:31
@elvin-n
Copy link
Contributor Author

elvin-n commented Jul 18, 2022

@elvin-n Can you add tests?

Added test

@masahi masahi merged commit 6bad21e into apache:main Jul 18, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
)

* [Texture] Add 2d memory support into static memory planner

Co-authored-by: Chris Sullivan <csullivan@octoml.ai>

* Add test verifying GraphPlanMemory work for 2d memory

Co-authored-by: Chris Sullivan <csullivan@octoml.ai>
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
)

* [Texture] Add 2d memory support into static memory planner

Co-authored-by: Chris Sullivan <csullivan@octoml.ai>

* Add test verifying GraphPlanMemory work for 2d memory

Co-authored-by: Chris Sullivan <csullivan@octoml.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants