[TOPI][Hexagon] Implement Argmax Slice Op #11847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrdadh
requested changes
Jun 24, 2022
| from ..infrastructure import allocate_hexagon_array, transform_numpy | ||
|
|
||
|
|
||
| # pylint: disable=invalid-name |
There was a problem hiding this comment.
please remove and make sure lint passes.
mehrdadh
reviewed
Jun 24, 2022
| transformed_expected_output_np, | ||
| 1e-3, | ||
| 1e-3, | ||
| ) |
There was a problem hiding this comment.
add this at the end of the test file:
if __name__ == "__main__":
tvm.testing.main()
There was a problem hiding this comment.
Hi @mehrdadh , Thank you for your time and inputs. Addressed the comments.
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
* [TOPI][Hexagon] Implement Argmax Slice Op * run through black * Address initial review comments * Fix variable names in tests * Fix lint issue Co-authored-by: arangasa (generated by with_the_same_user script) <arangasa@hu-arangasa-hyd.qualcomm.com>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
* [TOPI][Hexagon] Implement Argmax Slice Op * run through black * Address initial review comments * Fix variable names in tests * Fix lint issue Co-authored-by: arangasa (generated by with_the_same_user script) <arangasa@hu-arangasa-hyd.qualcomm.com>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* [TOPI][Hexagon] Implement Argmax Slice Op * run through black * Address initial review comments * Fix variable names in tests * Fix lint issue Co-authored-by: arangasa (generated by with_the_same_user script) <arangasa@hu-arangasa-hyd.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @mehrdadh