Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHOSN] Upgrade NPU driver stack to v22.05 #11759

Merged
merged 4 commits into from
Aug 2, 2022

Conversation

lhutton1
Copy link
Contributor

In updating the driver stack to v22.05 some additional things needed changes:

  • Prevent split being offloaded to the NPU which is not supported in
    v22.05.
  • Removes compile algorithm configuration option since this was removed
    in v22.05. Versions before v22.05 will use the default option.
  • Managing some API changes.
  • Updating network compile hashes.
  • Updating expected error message for overall scale bounds check.

cc @Leo-arm

@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

@lhutton1 lhutton1 force-pushed the ethosn-22.05 branch 2 times, most recently from 65df115 to 67d18dc Compare June 27, 2022 09:50
@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

@lhutton1
Copy link
Contributor Author

lhutton1 commented Jul 8, 2022

friendly ping for review. also cc @manupa-arm @leandron

@lhutton1
Copy link
Contributor Author

friendly ping for review

Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

In updating the driver stack to v22.05 some additional things needed
changes:
* Prevent split being offloaded to the NPU which is not supported in
  v22.05.
* Removes compile algorithm configuration option since this was removed
  in v22.05. Versions before v22.05 will use the default option.
* Managing some API changes.
* Updating network compile hashes.
* Updating expected error message for overall scale bounds check.

Change-Id: I09343c398a1f47dec44e135ff8252a6315a9b63f
Change-Id: Ib1a34093b4011bdc20fca47d474eb1786218de98
For some reason PyTest evaluates the second skipif decorator even
if the first one marks the test to be skipped. Thus, meaning test
collection fails when we want to check the version. The workaround
is to return None when the version is not available.

Change-Id: I7cdd8cc70a9ee3c193e9a900f1011829538d975b
Change-Id: I7555c4a4d7db4f6c7aa8d476e39277fc5cba2f0d
@lhutton1 lhutton1 merged commit a9df801 into apache:main Aug 2, 2022
@lhutton1
Copy link
Contributor Author

lhutton1 commented Aug 2, 2022

Thanks @manupa-arm!

@lhutton1 lhutton1 deleted the ethosn-22.05 branch August 2, 2022 08:33
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
* [ETHOSN] Upgrade NPU driver stack to v22.05

In updating the driver stack to v22.05 some additional things needed
changes:
* Prevent split being offloaded to the NPU which is not supported in
  v22.05.
* Removes compile algorithm configuration option since this was removed
  in v22.05. Versions before v22.05 will use the default option.
* Managing some API changes.
* Updating network compile hashes.
* Updating expected error message for overall scale bounds check.

Change-Id: I09343c398a1f47dec44e135ff8252a6315a9b63f

* fix decorator evaluation order

Change-Id: Ib1a34093b4011bdc20fca47d474eb1786218de98

* Return none if version doesn't exist

For some reason PyTest evaluates the second skipif decorator even
if the first one marks the test to be skipped. Thus, meaning test
collection fails when we want to check the version. The workaround
is to return None when the version is not available.

Change-Id: I7cdd8cc70a9ee3c193e9a900f1011829538d975b

* Update resnet hash after rebase

Change-Id: I7555c4a4d7db4f6c7aa8d476e39277fc5cba2f0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants