[MetaSchedule] Developer Ergonomics Enhancement II #11727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
force-pushed
the
feature/2022-06-14/ms-ux-2
branch
2 times, most recently
from
7f26982 to
34ddf43
Compare
Hzfengsy
approved these changes
Jun 15, 2022
Follow-up of apache#11622, per discussion with @Kathryn-cat - [x] Allow using a string `"default"` in `TuneContext` to quickly specify a set of target-specific rules - [x] Enhance detection of `ScheduleFn` in `TuneContext` to make it easier for users to quickly try out template-driven scheduling on TIR. Next PR: - Add `TuneContext.tune` to allow directly tuning without task scheduler. Co-Authored-By: Kathryn (Jinqi) Chen <65606304+Kathryn-cat@users.noreply.github.com>
junrushao
force-pushed
the
feature/2022-06-14/ms-ux-2
branch
from
34ddf43 to
b977005
Compare
Kathryn-cat
reviewed
Jun 15, 2022
Kathryn-cat
reviewed
Jun 15, 2022
| if callable(space_generator): | ||
| space_generator = ScheduleFn(space_generator) | ||
| if isinstance(search_strategy, TuneConfig): | ||
| search_strategy = search_strategy.create_strategy() |
There was a problem hiding this comment.
I guess create_strategy hasn't been implemented yet in search strategy?
There was a problem hiding this comment.
There was a problem hiding this comment.
oops sorry! It's good for now.
|
@Kathryn-cat comments addressed! would love to have another round of review :-) thanks! |
|
LGTM! |
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #11622, per discussion with @Kathryn-cat
"default"inTuneContextto quickly specify a set of target-specificrules
ScheduleFninTuneContextto make it easier for users to quickly tryout template-driven scheduling on TIR.
Next PR:
TuneContext.tuneto allow directly tuning without task scheduler.