Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM] Update pyproject to python3.7 #11634

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jun 8, 2022

This PR fixes a dependency issue that was introduced by #10921
Also this PR adds the poetry.lock file so make RVM provision faster.

cc @alanmacd @areusch @gromero

@github-actions github-actions bot requested a review from areusch June 8, 2022 22:55
@mehrdadh mehrdadh changed the title [microTVM] Update pyproject to python3.8 [microTVM] Update pyproject to python3.7 Jun 9, 2022
@github-actions github-actions bot requested a review from gromero June 9, 2022 17:19
@@ -28,9 +28,9 @@ apps/microtvm/reference-vm/rebuild-tvm.sh ${platform}
# Build poetry
cd apps/microtvm/reference-vm/arduino

poetry env use 3.6
poetry env use 3.7
# NOTE: due to https://github.com/python-poetry/poetry/issues/2247, download torch here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are checking in poetry.lock now (imo the right thing to do), shall we rm poetry lock -vvv below?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep.

@mehrdadh mehrdadh requested a review from areusch June 9, 2022 19:00
@mehrdadh mehrdadh merged commit d03633f into apache:main Jun 9, 2022
@mehrdadh mehrdadh deleted the microtvm/fix_dependency branch June 9, 2022 23:00
Kathryn-cat pushed a commit to Kathryn-cat/tvm that referenced this pull request Jun 10, 2022
* Update to python3.7 and add poetry.lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants