Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU] Reorder copies and computes based on the cycle count #11591

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

ekalda
Copy link
Contributor

@ekalda ekalda commented Jun 6, 2022

If the cascader is enabled and the ops in TIR have the cycle
count annotation, enabling the reorder_by_cycles option will
reorder to copies and computes based on a cycle count.

If reorder_by_cycles is enabled, max_copy_movements is ignored.

This pass is currently not part of the TIR pipeline since it
assumes that weights and bias of a compute op are merged into
one constant (which is WIP).

cc @Mousius @lhutton1

@ekalda
Copy link
Contributor Author

ekalda commented Jun 6, 2022

cc: @manupa-arm @NicolaLancellotti

@github-actions github-actions bot requested review from Mousius and lhutton1 June 6, 2022 15:33
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekalda, looks good! I just had a couple of questions/comments

src/tir/contrib/ethosu/passes.cc Show resolved Hide resolved
python/tvm/relay/backend/contrib/ethosu/tir/passes.py Outdated Show resolved Hide resolved
@ekalda ekalda force-pushed the copy-compute-reorder-compute-cycles branch from 6db2133 to 55816cc Compare July 14, 2022 12:49
Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will leave for others to take a look as well

If the cascader is enabled and the ops in TIR have the cycle
count annotation, enabling the reorder_by_cycles option will
reorder to copies and computes based on a cycle count.

If reorder_by_cycles is enabled, max_copy_movements is ignored.

This pass is currently not part of the TIR pipeline since it
assumes that weights and bias of a compute op are merged into
one constant (which is WIP).
@ekalda ekalda force-pushed the copy-compute-reorder-compute-cycles branch from 55816cc to dd29f9f Compare August 12, 2022 12:42
@Mousius Mousius merged commit d874a8e into apache:main Aug 12, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
…he#11591)

If the cascader is enabled and the ops in TIR have the cycle
count annotation, enabling the reorder_by_cycles option will
reorder to copies and computes based on a cycle count.

If reorder_by_cycles is enabled, max_copy_movements is ignored.

This pass is currently not part of the TIR pipeline since it
assumes that weights and bias of a compute op are merged into
one constant (which is WIP).
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
…he#11591)

If the cascader is enabled and the ops in TIR have the cycle
count annotation, enabling the reorder_by_cycles option will
reorder to copies and computes based on a cycle count.

If reorder_by_cycles is enabled, max_copy_movements is ignored.

This pass is currently not part of the TIR pipeline since it
assumes that weights and bias of a compute op are merged into
one constant (which is WIP).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants