[TVMScript] Represent ramp as index slice #11308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrongtest-intellif
force-pushed
the
support_ramp_sugar_as_index_slice
branch
from
1ceb8b3 to
3cc3dc8
Compare
Hzfengsy
approved these changes
May 13, 2022
| T.evaluate(T.call_extern("strided_compute", dtype="")) | ||
|
|
||
|
|
||
| def strided_buffer_region(A: T.handle): |
|
|
||
|
|
||
| def access_non_const_slice(A: T.handle): | ||
| # do not allow reversed slice step |
|
CC @yelite would you mind taking a look as well? |
yelite
approved these changes
May 14, 2022
junrushao
approved these changes
May 14, 2022
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 16, 2022
* support represent ramp as index slice in tvmscript * fix testcase's comment, check slice lanes instead of extent
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
* support represent ramp as index slice in tvmscript * fix testcase's comment, check slice lanes instead of extent
shingjan
pushed a commit
to shingjan/tvm
that referenced
this pull request
May 17, 2022
* support represent ramp as index slice in tvmscript * fix testcase's comment, check slice lanes instead of extent
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, the PR propose to represent
tir.RampNodein buffer access index just as python slice. I believe this could be a more user friendly way for script users on SIMD-based target, since it just mimic usages in various python numerical libraries like numpy.For example:
A[T.ramp(0, 1, 1024)]=>A[0:1024]A[T.ramp(i*32, 1, 32)]=>A[i*32:i*32+32]A[T.ramp(i*4, 4, 32)]=>A[i*4:i*4+128:4]The syntax sugar is only available for constant stride and lanes. Also please correct me on two points:
Slicewith non-trivial step is only allowed in buffer indices, we may want to ensure all other usages should check step==1.cc @junrushao1994 @Hzfengsy @Lunderberg