[microNPU] Expose compute cycle annotations to TIR lowering #11288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lhutton1! I'd suggest let us use "compute_cycles_hint" to make it closer to what it really is. Also, do you think that we would be able to add a RelayToTIR(...) hook test that shows the annotations ? |
lhutton1
force-pushed
the
add-compute-cycles-pragma
branch
from
0ac943b to
84ad95a
Compare
|
Thanks for the review @manupa-arm, I've pushed those changes |
lhutton1
force-pushed
the
add-compute-cycles-pragma
branch
from
84ad95a to
a8f9bb2
Compare
lhutton1
force-pushed
the
add-compute-cycles-pragma
branch
from
a8f9bb2 to
954c56e
Compare
|
@lhutton1 FYI, I think this patch needs to be rebased on top of #10959. If I run your patch locally on top of the copy compute reordering patch, it fails in so we shouldn't merge it before the rebase is done, despite CI being green... |
Adds an AttrSttmt "compute_cycles_hint" to each NPU operation for later passes to consume. Change-Id: I09779bdab6de6ef2094db610bb20d6e052e68ee3
Change-Id: Iebd71e699522e92a28fd321ffdb41ed7924db4e0
Change-Id: Idcdcc8c8b5536c4732f297246b71aa8378a2732c
Change-Id: I007ba19732e16081fa2ea9baca40c64a653c93cf
Change-Id: Ib812c4151fab03f4c1adcc016b4e798003a22e5e
lhutton1
force-pushed
the
add-compute-cycles-pragma
branch
from
954c56e to
e5a7542
Compare
|
Thanks @lhutton1 @ekalda @NicolaLancellotti ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an AttrSttmt "compute_cycles" to each NPU operation for later passes to consume.
cc @Mousius @NicolaLancellotti @ekalda @manupa-arm