-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch #10817
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
df00427
[CMSIS-NN] Aligned scale computation with TFLM to fix numerical mismatch
ashutosh-arm 9d01937
[CMSIS-NN] Added TFLite test for conv2d
ashutosh-arm a3d0b2f
Removed a misleading redundant comment in the test
ashutosh-arm b93a071
[CMSIS-NN] Select old TFLite interepreter for versions below TFLite2.5
ashutosh-arm 963170b
Fix CI ImportError by moving OpResolver import inside TFLite version …
ashutosh-arm bcb0b50
Fix for lint error upstream
ashutosh-arm b92aefd
[CMSIS-NN] skip test if import tflite fails
ashutosh-arm a636dcb
[CMSIS-NN] Fixed i386 CI failure because of tflite import
ashutosh-arm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this assert that it matches the expected output? Similar to how the NPU tests check that they are consistent with TFLite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we could compare against TFLite output. So far all the CMSIS-NN tests compare against TVM output.