Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM][Zephyr] Update RVM to Zephyr 2.7 #10138

Merged
merged 8 commits into from
Feb 3, 2022

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Feb 2, 2022

This PR:

  • Updates Zephyr version on RVM to 2.7-branch
  • Refactor duplication of zephyr branch and zephyr sdk version
  • Fix tests for version upgrade

cc @Mousius @areusch @gromero

set -o pipefail
set -x

INSTALLATION_PATH=$1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set a default or exit in error in case this mandatory parameter is not provided?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Mousius
Mousius previously requested changes Feb 2, 2022
@mehrdadh mehrdadh changed the title [microTVM][Zephyr] Update RVM to Zephyr 2.7 [microTVM][Zephyr] Update RVM to Zephyr 2.7 [Do not merge yet] Feb 2, 2022
set -o pipefail
set -x

INSTALLATION_PATH=$1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@@ -16,7 +16,7 @@
# under the License.

Vagrant.configure("2") do |config|
config.vm.box = "tlcpack/microtvm-zephyr-2.5"
config.vm.box = "tlcpack/microtvm-zephyr-2.7-staging"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is temporary for testing. I will rename it before merging.

@github-actions github-actions bot requested a review from Mousius February 2, 2022 16:59
@Mousius Mousius self-assigned this Feb 2, 2022
@mehrdadh
Copy link
Member Author

mehrdadh commented Feb 2, 2022

Built the ci_qemu image after these changes and it passes microtvm tests.

@mehrdadh mehrdadh changed the title [microTVM][Zephyr] Update RVM to Zephyr 2.7 [Do not merge yet] [microTVM][Zephyr] Update RVM to Zephyr 2.7 Feb 3, 2022
@mehrdadh
Copy link
Member Author

mehrdadh commented Feb 3, 2022

The image is ready and passed the tests on hardware, we are good to merge this.
@leandron PTAL, thanks!

@mehrdadh
Copy link
Member Author

mehrdadh commented Feb 3, 2022

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes @mehrdadh

@leandron leandron merged commit 506bc3c into apache:main Feb 3, 2022
@mehrdadh mehrdadh deleted the test-zephyr-2.7 branch February 3, 2022 18:48
mbs-octoml pushed a commit to mbs-octoml/mbs-tvm that referenced this pull request Feb 5, 2022
* Update to zephyr2.7 and Refactor

* Temporary for testing

* Update cmake version

* fix import path and format

* Fix test script

* address comments

* fix path

* fix image name
ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022
* Update to zephyr2.7 and Refactor

* Temporary for testing

* Update cmake version

* fix import path and format

* Fix test script

* address comments

* fix path

* fix image name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants