-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microTVM][Zephyr] Update RVM to Zephyr 2.7 #10138
Conversation
set -o pipefail | ||
set -x | ||
|
||
INSTALLATION_PATH=$1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you set a default or exit in error in case this mandatory parameter is not provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
set -o pipefail | ||
set -x | ||
|
||
INSTALLATION_PATH=$1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
@@ -16,7 +16,7 @@ | |||
# under the License. | |||
|
|||
Vagrant.configure("2") do |config| | |||
config.vm.box = "tlcpack/microtvm-zephyr-2.5" | |||
config.vm.box = "tlcpack/microtvm-zephyr-2.7-staging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is temporary for testing. I will rename it before merging.
Built the ci_qemu image after these changes and it passes microtvm tests. |
The image is ready and passed the tests on hardware, we are good to merge this. |
link to image: https://app.vagrantup.com/tlcpack/boxes/microtvm-zephyr-2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fixes @mehrdadh
* Update to zephyr2.7 and Refactor * Temporary for testing * Update cmake version * fix import path and format * Fix test script * address comments * fix path * fix image name
* Update to zephyr2.7 and Refactor * Temporary for testing * Update cmake version * fix import path and format * Fix test script * address comments * fix path * fix image name
This PR:
cc @Mousius @areusch @gromero