Fix JUnit failure reporting #10121
Merged
Fix JUnit failure reporting #10121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
areusch
and removed request for
a team
|
It has been a while since this PR was updated, @areusch please leave a review or address the outstanding comments |
driazati
requested review from
comaniac,
junrushao,
tqchen,
jroesch,
yzhliu,
merrymercy and
icemelon
as code owners
|
Branch check is away! |
areusch
approved these changes
Feb 16, 2022
|
thanks @driazati ! |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Fix spacing * Add try..finally everywhere * trigger ci * Fix pytest invocations * Remove junit collection where no files exist Co-authored-by: driazati <driazati@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only collect reports when the
junitfunction runs in the Jenkinsfile, which only happens if the earlier test scripts didn't fail. We should always try to collect whatever reports are there, so this wraps everything intry..finallywhich is apparently the only way to do this in a scripted pipeline (another point where moving to a declarative pipeline would simplify things). A bunch of the JUnits are also colliding and getting overwritten before Jenkins ingests them, so this fixes that as well.Note for reviewing: first commit is all whitespace, see this commit for significant changes
cc @areusch @Mousius