-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Currently, the Target does two independent tasks: (1) defining which device owns the buffers that are passed as input to a PrimFunc, and (2) defining which codegen will be used for a PrimFunc. Prior to this commit, the "ext_dev" target was required to define the device ownership, but did not provide the `"target.build.ext_dev"` function that is required for codegen. This worked, because `SplitHostDevice` would remove the `"ext_dev"` target without making a device-side function. With the single-module lowering flow, the separate device-side function is required to support UMA codegen. To resolve this issue, `"ext_dev"` now provides a codegen function, which is identical to the LLVM codegen. This may be improved in the future by allowing the buffer device and the codegen to be specified independently.
- Loading branch information
1 parent
888130d
commit d3ddd40
Showing
3 changed files
with
12 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters