Skip to content

Commit

Permalink
[Vulkan] Remote target.h #include
Browse files Browse the repository at this point in the history
Was added in #8127, should have been removed in #8171 along with the
rest of the references outside of libtvm_runtime.so.  This didn't
impact the Vulkan+g++ builds, because no symbols were accessed outside
of the runtime library.  However, it broke the Vulkan+Windows builds,
which expected symbols due to the `__declspec(dllexport)` defintion of
`TVM_DLL` on MSVC (see #8805).  This wasn't caught by the CI build on
Windows, because it doesn't perform the Vulkan build.
  • Loading branch information
Lunderberg committed Aug 23, 2021
1 parent 10fca9c commit 9a19a4d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/runtime/vulkan/vulkan_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <tvm/runtime/device_api.h>
#include <tvm/runtime/logging.h>
#include <tvm/runtime/packed_func.h>
#include <tvm/target/target.h>
#include <tvm/runtime/registry.h>
#include <vulkan/vulkan.h>

#include <memory>
Expand Down

0 comments on commit 9a19a4d

Please sign in to comment.