Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Autest for H2 CONNECT and fix a crash triggered by the test #9781

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

lzx404243
Copy link
Collaborator

@lzx404243 lzx404243 commented Jun 6, 2023

In #9616, @maskit wrote an H2 CONNECT Autest but couldn't include that in the final PR because of a Proxy Verifier issue.
Now that the Proxy Verifier issue is resolved, the Autest is added in this PR(with a few tweaks).

ATS crashes with the new test executing HTTP/2 tunneling traffic. This PR also includes a fix to resolve that.

@lzx404243 lzx404243 self-assigned this Jun 6, 2023
@lzx404243 lzx404243 modified the milestones: 10.0.0, 9.2.1 Jun 6, 2023
@lzx404243
Copy link
Collaborator Author

Note: The updated connect Autest is dependent on a newer release of Proxy Verifier. It would fail before the Proxy Verifier version is updated in ATS testing.

@lzx404243 lzx404243 marked this pull request as draft June 6, 2023 19:19
@lzx404243 lzx404243 force-pushed the h2-connect-pv-fix branch from 218f0a3 to 745c61a Compare June 13, 2023 19:26
@lzx404243 lzx404243 marked this pull request as ready for review June 13, 2023 19:26
@bneradt
Copy link
Contributor

bneradt commented Jun 13, 2023

Note: The updated connect Autest is dependent on a newer release of Proxy Verifier. It would fail before the Proxy Verifier version is updated in ATS testing.

Just to record it, Proxy Verifier was updated to the required v2.8.1 via: #9834

@bneradt bneradt merged commit df7ccfe into apache:master Jun 25, 2023
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 19, 2023
These are cherry-picks from asf that has the fix for crash caused by H2 CONNECT.
* Added http connect Autest with proxy verifier (apache#9315)

* Added a HTTP CONNECT test using proxy verifier

* Updated comment

* added proxy-response verification

(cherry picked from commit b5f2023)

* Added Autest for H2 CONNECT and fix a crash triggered by the test (apache#9781)

In apache#9616, @maskit wrote an H2 CONNECT Autest but couldn't include that in the final PR because of a Proxy Verifier issue.
Now that the Proxy Verifier issue is resolved, the Autest is added in this PR(with a few tweaks).

ATS crashes with the new test executing HTTP/2 tunneling traffic. This PR also includes a fix to resolve that.

(cherry picked from commit df7ccfe)

* Update to Proxy Verifier v2.8.1 (apache#9834)

Proxy Verifier v2.8.1 has fixes for the way Proxy Verifier relates to
HTTP/2 CONNECT method request pseudo header fields. This will be helpful
for testing HTTP/2 CONNECT requests.

(cherry picked from commit d5c47a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants