Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the cmake hwloc processing unit support test to use the hwloc include directory #12033

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Update the cmake hwloc processing unit support test to use the hwloc include directory #12033

merged 1 commit into from
Feb 18, 2025

Conversation

bryancall
Copy link
Contributor

No description provided.

@bryancall bryancall added the CMake work related to CMakes scripts or issues label Feb 12, 2025
@bryancall bryancall added this to the 10.1.0 milestone Feb 12, 2025
@bryancall bryancall self-assigned this Feb 12, 2025
@phongn phongn requested review from cmcfarlen and JosiahWI February 13, 2025 17:55
@JosiahWI
Copy link
Contributor

Do we not need to provide the hwloc library path? Does the check not have to perform the linking step?

JosiahWI
JosiahWI approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@JosiahWI JosiahWI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to link libhwloc for the check, because it doesn't depend on any symbols other than the define that would be in the hwloc header.

@bryancall bryancall merged commit 712572a into apache:master Feb 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phongn phongn phongn approved these changes

@JosiahWI JosiahWI JosiahWI approved these changes

@cmcfarlen cmcfarlen Awaiting requested review from cmcfarlen

Assignees

@bryancall bryancall

Labels
CMake work related to CMakes scripts or issues
Projects
None yet
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bryancall @JosiahWI @phongn