Skip to content

PR Review comment Updates for https://github.com/apache/trafficcontr…

Codecov / codecov/patch succeeded Jul 21, 2023 in 1s

2.51% of diff hit (target 32.34%)

View this Pull Request on Codecov

2.51% of diff hit (target 32.34%)

Annotations

Check warning on line 2248 in traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go#L2237-L2248

Added lines #L2237 - L2248 were not covered by tests

Check warning on line 247 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L223-L247

Added lines #L223 - L247 were not covered by tests

Check warning on line 260 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L249-L260

Added lines #L249 - L260 were not covered by tests

Check warning on line 277 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L262-L277

Added lines #L262 - L277 were not covered by tests

Check warning on line 281 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L280-L281

Added lines #L280 - L281 were not covered by tests

Check warning on line 297 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L284-L297

Added lines #L284 - L297 were not covered by tests

Check warning on line 312 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L300-L312

Added lines #L300 - L312 were not covered by tests

Check warning on line 325 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L316-L325

Added lines #L316 - L325 were not covered by tests

Check warning on line 370 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L328-L370

Added lines #L328 - L370 were not covered by tests

Check warning on line 375 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L372-L375

Added lines #L372 - L375 were not covered by tests

Check warning on line 391 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L378-L391

Added lines #L378 - L391 were not covered by tests

Check warning on line 406 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L394-L406

Added lines #L394 - L406 were not covered by tests

Check warning on line 414 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L409-L414

Added lines #L409 - L414 were not covered by tests

Check warning on line 420 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L416-L420

Added lines #L416 - L420 were not covered by tests

Check warning on line 468 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L423-L468

Added lines #L423 - L468 were not covered by tests

Check warning on line 472 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L470-L472

Added lines #L470 - L472 were not covered by tests

Check warning on line 497 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L475-L497

Added lines #L475 - L497 were not covered by tests

Check warning on line 506 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L499-L506

Added lines #L499 - L506 were not covered by tests

Check warning on line 524 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L508-L524

Added lines #L508 - L524 were not covered by tests

Check warning on line 532 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L527-L532

Added lines #L527 - L532 were not covered by tests

Check warning on line 547 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L535-L547

Added lines #L535 - L547 were not covered by tests

Check warning on line 555 in traffic_ops/traffic_ops_golang/physlocation/phys_locations.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

traffic_ops/traffic_ops_golang/physlocation/phys_locations.go#L551-L555

Added lines #L551 - L555 were not covered by tests